Added collapsable nav bar. Moved buttons to line up#1
Open
Dmart331 wants to merge 3 commits intodeepforge-dev:masterfrom
Open
Added collapsable nav bar. Moved buttons to line up#1Dmart331 wants to merge 3 commits intodeepforge-dev:masterfrom
Dmart331 wants to merge 3 commits intodeepforge-dev:masterfrom
Conversation
Contributor
|
It's showing up a little funny for me:
|
Author
|
Strange! Ill look into it. I was testing on mobile so it looked a little
different. Sorry man!!!!
…On Mar 28, 2017 8:46 PM, "Brian Broll" ***@***.***> wrote:
It's showing up a little funny for me:
[image: snap0006]
<https://cloud.githubusercontent.com/assets/4982789/24434575/0f074ffc-13f6-11e7-9e47-d18451a93fa6.png>
- The white gap below the header is a little odd
- The css updated for the anchors are showing up a little on the small
side
- the added left margin to the logo looks better
- The header fonts look a little on the smaller side (esp in the
section headers)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ASTTgEMt3Q5rDTWSNE_VAO99h0JkPHdgks5rqbf_gaJpZM4MsNJk>
.
|
Contributor
|
no worries! |
Author
|
Allllllrighty check it out. Play with the screen width and make sure it is
as responsive as i think it is
…On Tue, Mar 28, 2017 at 9:08 PM, Brian Broll ***@***.***> wrote:
no worries!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ASTTgCAD1vZ0Gg5YLYMKgGezEvxehMwhks5rqb02gaJpZM4MsNJk>
.
--
Drew Martin
Full Stack Developer
(615)481-0464
dmart331.github.io
|
Contributor
|
A couple comments:
The main screenshot seems much more responsive though! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Navigate to lib folder. Run
npm installthenbower installReally all I changed was adding the collapsable nav when the browser window is smaller than a computer. Viewing on the phone should be a little smoother now. Let me know if I completely messed something up.